Bump/nodejs v18 #1595
Merged
Bump/nodejs v18 #1595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0e7cd87.
|
@RodriSanchez1 Shouldn't we remove the |
|
@RodriSanchez1 Just installed dependencies and run and got the following error:
|
No, we still use it. But an update to
Do you change your node version to v18.18.1 before build? On my pc is building well. |
shayc
reviewed
Oct 25, 2023
| "start": "react-scripts start", | ||
| "build": "react-scripts build && sw-precache --config=sw-precache-config.js", | ||
| "start": "craco start", | ||
| "build": "craco build && sw-precache --config=sw-precache-config.js", | ||
| "build-cordova-debug": "react-app-rewired build", |
There was a problem hiding this comment.
is react-app-rewired needed? can you use craco instead? (i'm not sure)
There was a problem hiding this comment.
Yes we can remove it. I will do that in other PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On this PR:
v18.18.1. The new version was pinned on docker file,.nvmrcand CI config.NOTE: We are currently react-rewire (similiar than CRACO) but is not maintened anymore. Needs to migrate.
--maxWorkers=50%for--runInBandon CI config. This change was made because the Unit Test were hanging with no output response. Also increment the run speed of the test.Import.constants.jsandExport.helpers.jsWelcomeScreen.cssopenDbimport onarasaac.tsyarn.lockfile